Merged
Conversation
frostbyte73
requested review from
biglittlebigben,
boks1971,
davidzhao,
dennwc and
paulwe
🦋 Changeset detectedLatest commit: c951d3d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR 💥 An error occurred when fetching the changed packages and changesets in this PR |
boks1971
reviewed
Jul 8, 2024
Contributor
boks1971
left a comment
boks1971
left a comment
There was a problem hiding this comment.
Is this okay in oss? Guess it is needed here?
biglittlebigben
approved these changes
Jul 8, 2024
Member
Author
It's cloud only, but the APIs will need to be available to the clients |
boks1971
approved these changes
Jul 8, 2024
paulwe
reviewed
Jul 8, 2024
| string replay_id = 1; | ||
| } | ||
|
|
||
| message RoomSeekRequest { |
Contributor
There was a problem hiding this comment.
should this have replay somewhere in the name?
paulwe
approved these changes
Jul 8, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.